ratelimit: Drop redundant accesses to burst
authorPaul E. McKenney <paulmck@kernel.org>
Thu, 24 Apr 2025 19:36:19 +0000 (12:36 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Thu, 8 May 2025 23:13:27 +0000 (16:13 -0700)
Now that there is the "burst <= 0" fastpath, for all later code, burst
must be strictly greater than zero.  Therefore, drop the redundant checks
of this local variable.

Link: https://lore.kernel.org/all/fbe93a52-365e-47fe-93a4-44a44547d601@paulmck-laptop/
Link: https://lore.kernel.org/all/20250423115409.3425-1-spasswolf@web.de/
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
lib/ratelimit.c

index dcc063af195eb95a50d0134ef76ba7ac8c7cbe29..859c251b23ce23ec2a643fcc52a29af0e3171276 100644 (file)
@@ -58,7 +58,7 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
         * the current lock owner is just about to reset it.
         */
        if (!raw_spin_trylock_irqsave(&rs->lock, flags)) {
-               if (READ_ONCE(rs->flags) & RATELIMIT_INITIALIZED && burst &&
+               if (READ_ONCE(rs->flags) & RATELIMIT_INITIALIZED &&
                    atomic_read(&rs->rs_n_left) > 0 && atomic_dec_return(&rs->rs_n_left) >= 0)
                        ret = 1;
                goto nolock_ret;
@@ -90,7 +90,7 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
        }
 
        /* Note that the burst might be taken by a parallel call. */
-       if (burst && atomic_read(&rs->rs_n_left) > 0 && atomic_dec_return(&rs->rs_n_left) >= 0)
+       if (atomic_read(&rs->rs_n_left) > 0 && atomic_dec_return(&rs->rs_n_left) >= 0)
                ret = 1;
 
 unlock_ret: