video: fbdev: atmel_lcdfb: fix return error code in atmel_lcdfb_of_init()

If devm_kzalloc() failed after the first time, atmel_lcdfb_of_init()
can't return -ENOMEM, fix this by putting the error code in loop.

Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20201117061350.3453742-1-yangyingliang@huawei.com

diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
index 8c1d47e52b1a6bce69bd371017f57592fa1dce57..355b6120dc4f0dcd77433ac4c8753ffa5561e8af 100644 (file)
--- a/drivers/video/fbdev/atmel_lcdfb.c
+++ b/drivers/video/fbdev/atmel_lcdfb.c
@@ -987,8 +987,8 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
        }
 
        INIT_LIST_HEAD(&pdata->pwr_gpios);
-       ret = -ENOMEM;
        for (i = 0; i < gpiod_count(dev, "atmel,power-control"); i++) {
+               ret = -ENOMEM;
                gpiod = devm_gpiod_get_index(dev, "atmel,power-control",
                                             i, GPIOD_ASIS);
                if (IS_ERR(gpiod))