can: xilinx_can: xcan_remove(): remove redundant netif_napi_del()
authorDongliang Mu <mudongliangabcd@gmail.com>
Sun, 17 Oct 2021 12:50:21 +0000 (20:50 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 24 Oct 2021 14:26:05 +0000 (16:26 +0200)
Since netif_napi_del() is already done in the free_candev(), we remove
this redundant netif_napi_del() invocation. In addition, this patch
can match the operations in the xcan_probe() and xcan_remove()
functions.

Link: https://lore.kernel.org/all/20211017125022.3100329-1-mudongliangabcd@gmail.com
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/xilinx_can.c

index 85c2ed5df4c7a1eee8cb38212944e30854b038a9..e2b15d29d15eb5b75c4a721a2fd3423a96628c2b 100644 (file)
@@ -1843,11 +1843,9 @@ err:
 static int xcan_remove(struct platform_device *pdev)
 {
        struct net_device *ndev = platform_get_drvdata(pdev);
-       struct xcan_priv *priv = netdev_priv(ndev);
 
        unregister_candev(ndev);
        pm_runtime_disable(&pdev->dev);
-       netif_napi_del(&priv->napi);
        free_candev(ndev);
 
        return 0;