drm/msm: Use drm_sched_job_add_syncobj_dependency()
authorMaíra Canal <mcanal@igalia.com>
Fri, 24 Feb 2023 21:41:33 +0000 (18:41 -0300)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thu, 6 Apr 2023 17:29:39 +0000 (20:29 +0300)
As msm_parse_deps() performs the same steps as
drm_sched_job_add_syncobj_dependency(), replace the open-coded
implementation in msm in order to simply use the DRM function.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
Patchwork: https://patchwork.freedesktop.org/patch/524090/
Link: https://lore.kernel.org/r/20230224214133.411966-2-mcanal@igalia.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/msm_gem_submit.c

index 89375c2e422bed98548e56ee80d24e2ed33dce88..aff18c2f600ab2050d52cd05ba924d3b4ae68a20 100644 (file)
@@ -573,7 +573,6 @@ static struct drm_syncobj **msm_parse_deps(struct msm_gem_submit *submit,
 
        for (i = 0; i < nr_in_syncobjs; ++i) {
                uint64_t address = in_syncobjs_addr + i * syncobj_stride;
-               struct dma_fence *fence;
 
                if (copy_from_user(&syncobj_desc,
                                   u64_to_user_ptr(address),
@@ -593,12 +592,8 @@ static struct drm_syncobj **msm_parse_deps(struct msm_gem_submit *submit,
                        break;
                }
 
-               ret = drm_syncobj_find_fence(file, syncobj_desc.handle,
-                                            syncobj_desc.point, 0, &fence);
-               if (ret)
-                       break;
-
-               ret = drm_sched_job_add_dependency(&submit->base, fence);
+               ret = drm_sched_job_add_syncobj_dependency(&submit->base, file,
+                                                          syncobj_desc.handle, syncobj_desc.point);
                if (ret)
                        break;