drm/i915: Move the SDP split debug spew to the correct place
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 22 Nov 2023 09:31:37 +0000 (11:31 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 24 Nov 2023 07:40:30 +0000 (09:40 +0200)
Adding ad-hoc debug prints all over the place is not good.
Move the SDP split debug spew into the proper place (state
dumper).

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231122093137.1509-4-ville.syrjala@linux.intel.com
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
drivers/gpu/drm/i915/display/intel_dp.c

index 66fe880af8f3f01efa461046dfa18a84aa0a8f62..30336453041d1beddacca4acef101f5f0da6a660 100644 (file)
@@ -261,6 +261,9 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
                drm_dbg_kms(&i915->drm, "fec: %s, enhanced framing: %s\n",
                            str_enabled_disabled(pipe_config->fec_enable),
                            str_enabled_disabled(pipe_config->enhanced_framing));
+
+               drm_dbg_kms(&i915->drm, "sdp split: %s\n",
+                           str_enabled_disabled(pipe_config->sdp_split_enable));
        }
 
        drm_dbg_kms(&i915->drm, "framestart delay: %d, MSA timing delay: %d\n",
index 6d5a794b6b7173cee59f63e50a6aa693112aa2de..f9b5fc2fdbcb92b0daee7ea28e9b14b430e8e149 100644 (file)
@@ -2844,19 +2844,12 @@ intel_dp_audio_compute_config(struct intel_encoder *encoder,
                              struct intel_crtc_state *pipe_config,
                              struct drm_connector_state *conn_state)
 {
-       struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-       struct drm_connector *connector = conn_state->connector;
-
        pipe_config->has_audio =
                intel_dp_has_audio(encoder, pipe_config, conn_state) &&
                intel_audio_compute_config(encoder, pipe_config, conn_state);
 
        pipe_config->sdp_split_enable = pipe_config->has_audio &&
                                        intel_dp_is_uhbr(pipe_config);
-
-       drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] SDP split enable: %s\n",
-                   connector->base.id, connector->name,
-                   str_yes_no(pipe_config->sdp_split_enable));
 }
 
 int