nvmet-tcp: simplify nvmet_process_resp_list

We can make it shorter and simpler without some redundant checks.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
index 1ce22b698f4ddca0cf1a49cd58a37ce29463f3ce..9eda91162fe45d1aba836bf3811015e115f5aec0 100644 (file)
--- a/drivers/nvme/target/tcp.c
+++ b/drivers/nvme/target/tcp.c
@@ -459,17 +459,11 @@ static void nvmet_setup_response_pdu(struct nvmet_tcp_cmd *cmd)
 static void nvmet_tcp_process_resp_list(struct nvmet_tcp_queue *queue)
 {
        struct llist_node *node;
+       struct nvmet_tcp_cmd *cmd;
 
-       node = llist_del_all(&queue->resp_list);
-       if (!node)
-               return;
-
-       while (node) {
-               struct nvmet_tcp_cmd *cmd = llist_entry(node,
-                                       struct nvmet_tcp_cmd, lentry);
-
+       for (node = llist_del_all(&queue->resp_list); node; node = node->next) {
+               cmd = llist_entry(node, struct nvmet_tcp_cmd, lentry);
                list_add(&cmd->entry, &queue->resp_send_list);
-               node = node->next;
                queue->send_list_len++;
        }
 }