s390/pci: remove redundant pci_bus_add_devices() on new bus
authorNiklas Schnelle <schnelle@linux.ibm.com>
Mon, 6 Mar 2023 15:10:13 +0000 (16:10 +0100)
committerVasily Gorbik <gor@linux.ibm.com>
Mon, 13 Mar 2023 08:16:43 +0000 (09:16 +0100)
The pci_bus_add_devices() call in zpci_bus_create_pci_bus() is without
function since at this point no device could have been added to the
freshly created PCI bus.

Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Link: https://lore.kernel.org/r/20230306151014.60913-4-schnelle@linux.ibm.com
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/pci/pci_bus.c

index 465399dc4a533cfbe0aeac525b65d9813d3a6681..df2e27fbd376b469b02b1399bcbec8dd50d46108 100644 (file)
@@ -212,7 +212,6 @@ static int zpci_bus_create_pci_bus(struct zpci_bus *zbus, struct zpci_dev *fr, s
        }
 
        zbus->bus = bus;
-       pci_bus_add_devices(bus);
 
        return 0;
 }