extcon: ptn5150: Reduce the amount of logs on deferred probe
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 17 Aug 2020 07:00:06 +0000 (09:00 +0200)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 24 Sep 2020 10:20:48 +0000 (19:20 +0900)
There is no point to print deferred probe (and its failures to get
resources) as an error.  In case of multiple probe tries this would
pollute the dmesg.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-ptn5150.c

index 008e664d8d56a82225cf5150248e85e2ef322cae..c8611ff909908329505f04ba78506a2d7c9b5a21 100644 (file)
@@ -243,7 +243,7 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
                        dev_info(dev, "No VBUS GPIO, ignoring VBUS control\n");
                        info->vbus_gpiod = NULL;
                } else {
-                       dev_err(dev, "failed to get VBUS GPIO\n");
+                       dev_err_probe(dev, ret, "failed to get VBUS GPIO\n");
                        return ret;
                }
        }
@@ -255,8 +255,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
        info->regmap = devm_regmap_init_i2c(i2c, &ptn5150_regmap_config);
        if (IS_ERR(info->regmap)) {
                ret = PTR_ERR(info->regmap);
-               dev_err(info->dev, "failed to allocate register map: %d\n",
-                                  ret);
+               dev_err_probe(info->dev, ret, "failed to allocate register map: %d\n",
+                             ret);
                return ret;
        }
 
@@ -265,8 +265,9 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
        } else {
                info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
                if (IS_ERR(info->int_gpiod)) {
-                       dev_err(dev, "failed to get INT GPIO\n");
-                       return PTR_ERR(info->int_gpiod);
+                       ret = PTR_ERR(info->int_gpiod);
+                       dev_err_probe(dev, ret, "failed to get INT GPIO\n");
+                       return ret;
                }
 
                info->irq = gpiod_to_irq(info->int_gpiod);