selftests: mptcp: add mptcp_lib_is_v6

To avoid duplicated code in different MPTCP selftests, we can add
and use helpers defined in mptcp_lib.sh.

is_v6() helper is defined in mptcp_connect.sh, mptcp_join.sh and
mptcp_sockopt.sh, so export it into mptcp_lib.sh and rename it as
mptcp_lib_is_v6(). Use this new helper in all scripts.

Reviewed-by: Matthieu Baerts <matttbe@kernel.org>
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231128-send-net-next-2023107-v4-10-8d6b94150f6b@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
index b1fc8afd072dc6ddde8d561a675a5549a9a37dba..4cf62b2b0480a2328deeb7c5291f0edd1fee2771 100755 (executable)
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
@@ -310,12 +310,6 @@ check_mptcp_disabled()
        return 0
 }
 
-# $1: IP address
-is_v6()
-{
-       [ -z "${1##*:*}" ]
-}
-
 do_ping()
 {
        local listener_ns="$1"
@@ -324,7 +318,7 @@ do_ping()
        local ping_args="-q -c 1"
        local rc=0
 
-       if is_v6 "${connect_addr}"; then
+       if mptcp_lib_is_v6 "${connect_addr}"; then
                $ipv6 || return 0
                ping_args="${ping_args} -6"
        fi
@@ -635,12 +629,12 @@ run_tests_lo()
        fi
 
        # skip if we don't want v6
-       if ! $ipv6 && is_v6 "${connect_addr}"; then
+       if ! $ipv6 && mptcp_lib_is_v6 "${connect_addr}"; then
                return 0
        fi
 
        local local_addr
-       if is_v6 "${connect_addr}"; then
+       if mptcp_lib_is_v6 "${connect_addr}"; then
                local_addr="::"
        else
                local_addr="0.0.0.0"
@@ -708,7 +702,7 @@ run_test_transparent()
        TEST_GROUP="${msg}"
 
        # skip if we don't want v6
-       if ! $ipv6 && is_v6 "${connect_addr}"; then
+       if ! $ipv6 && mptcp_lib_is_v6 "${connect_addr}"; then
                return 0
        fi
 
@@ -741,7 +735,7 @@ EOF
        fi
 
        local local_addr
-       if is_v6 "${connect_addr}"; then
+       if mptcp_lib_is_v6 "${connect_addr}"; then
                local_addr="::"
                r6flag="-6"
        else

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index e7557f6a0dc1e4914eff15db0a8f5a699df98a30..2ec5c5006d38e559c44899e5d2f7551d64ef62b4 100755 (executable)
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -587,12 +587,6 @@ link_failure()
        done
 }
 
-# $1: IP address
-is_v6()
-{
-       [ -z "${1##*:*}" ]
-}
-
 # $1: ns, $2: port
 wait_local_port_listen()
 {
@@ -895,7 +889,7 @@ pm_nl_set_endpoint()
                local id=10
                while [ $add_nr_ns1 -gt 0 ]; do
                        local addr
-                       if is_v6 "${connect_addr}"; then
+                       if mptcp_lib_is_v6 "${connect_addr}"; then
                                addr="dead:beef:$counter::1"
                        else
                                addr="10.0.$counter.1"
@@ -947,7 +941,7 @@ pm_nl_set_endpoint()
                local id=20
                while [ $add_nr_ns2 -gt 0 ]; do
                        local addr
-                       if is_v6 "${connect_addr}"; then
+                       if mptcp_lib_is_v6 "${connect_addr}"; then
                                addr="dead:beef:$counter::2"
                        else
                                addr="10.0.$counter.2"
@@ -989,7 +983,7 @@ pm_nl_set_endpoint()
                        pm_nl_flush_endpoint ${connector_ns}
                elif [ $rm_nr_ns2 -eq 9 ]; then
                        local addr
-                       if is_v6 "${connect_addr}"; then
+                       if mptcp_lib_is_v6 "${connect_addr}"; then
                                addr="dead:beef:1::2"
                        else
                                addr="10.0.1.2"
@@ -3357,7 +3351,7 @@ userspace_pm_rm_sf()
        local cnt
 
        [ "$1" == "$ns2" ] && evts=$evts_ns2
-       if is_v6 $2; then ip=6; fi
+       if mptcp_lib_is_v6 $2; then ip=6; fi
        tk=$(mptcp_lib_evts_get_info token "$evts")
        da=$(mptcp_lib_evts_get_info "daddr$ip" "$evts" $t)
        dp=$(mptcp_lib_evts_get_info dport "$evts" $t)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
index e421b658d748cfd46a090b741780054cd07015dd..447292cad33cd1bd8ee191eaf2f09bad70b29209 100644 (file)
--- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
@@ -226,3 +226,8 @@ mptcp_lib_kill_wait() {
        kill "${1}" > /dev/null 2>&1
        wait "${1}" 2>/dev/null
 }
+
+# $1: IP address
+mptcp_lib_is_v6() {
+       [ -z "${1##*:*}" ]
+}

diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
index a817af6616ec9602ba0bf4a3e4189318a5810b8c..bfa744e350eff246f8105d8f8e1342e7a9efc802 100755 (executable)
--- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
@@ -161,12 +161,6 @@ check_transfer()
        return 0
 }
 
-# $1: IP address
-is_v6()
-{
-       [ -z "${1##*:*}" ]
-}
-
 do_transfer()
 {
        local listener_ns="$1"
@@ -183,7 +177,7 @@ do_transfer()
        local mptcp_connect="./mptcp_connect -r 20"
 
        local local_addr ip
-       if is_v6 "${connect_addr}"; then
+       if mptcp_lib_is_v6 "${connect_addr}"; then
                local_addr="::"
                ip=ipv6
        else