arm64: dts: rockchip: fix regulator-gpio states array
authorJohan Jonker <jbx6244@gmail.com>
Mon, 10 May 2021 21:58:40 +0000 (23:58 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Fri, 14 May 2021 12:11:53 +0000 (14:11 +0200)
A test with the command below gives this error:

/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml:
sdmmcio-regulator: states:0:
[1800000, 1, 3300000, 0] is too long

dtbs_check expects regulator-gpio states in a format
of 2 per item, so fix them all.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/
regulator/gpio-regulator.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://lore.kernel.org/r/20210510215840.16270-1-jbx6244@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi

index 3dddd4742c3a0ea0cdcb1f92738103eb374e5deb..665b2e69455dd1c8363602db9f9b63219f7d4063 100644 (file)
@@ -84,8 +84,8 @@
                regulator-min-microvolt = <1800000>;
                regulator-max-microvolt = <3300000>;
                gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_HIGH>;
-               states = <1800000 0x0
-                         3300000 0x1>;
+               states = <1800000 0x0>,
+                        <3300000 0x1>;
                vin-supply = <&vcc5v0_sys>;
        };
 
index 64cf07ee3d10cb39cad98c529db475131336e8d1..3857d487ab84cfcd7aadec403a259f8a266987eb 100644 (file)
@@ -77,8 +77,8 @@
                regulator-settling-time-us = <5000>;
                regulator-type = "voltage";
                startup-delay-us = <2000>;
-               states = <1800000 0x1
-                         3300000 0x0>;
+               states = <1800000 0x1>,
+                        <3300000 0x0>;
                vin-supply = <&vcc_io_33>;
        };
 
index bdf0ca07eae9dade419eb84c0d17d6eac05deb51..aa22a0c222655f0616a2142f9e1e8d25642ad1c2 100644 (file)
@@ -50,8 +50,8 @@
        vcc_sdio: sdmmcio-regulator {
                compatible = "regulator-gpio";
                gpios = <&grf_gpio 0 GPIO_ACTIVE_HIGH>;
-               states = <1800000 0x1
-                         3300000 0x0>;
+               states = <1800000 0x1>,
+                        <3300000 0x0>;
                regulator-name = "vcc_sdio";
                regulator-type = "voltage";
                regulator-min-microvolt = <1800000>;
index beee5fbb3443774f285c9affe91a79373dfedab7..5d7a9d96d1633fe57f0929c7f05366afb00b31b5 100644 (file)
@@ -245,7 +245,7 @@ pp1800_pcie: &pp1800_s0 {
 };
 
 &ppvar_sd_card_io {
-       states = <1800000 0x0 3300000 0x1>;
+       states = <1800000 0x0>, <3300000 0x1>;
        regulator-max-microvolt = <3300000>;
 };
 
index 4002742fed4c13401627fccebb4debc7bd249759..c1bcc8ca3769d8e84bb5becfdce37cde05db8432 100644 (file)
                enable-active-high;
                enable-gpio = <&gpio2 2 GPIO_ACTIVE_HIGH>;
                gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
-               states = <1800000 0x1
-                         3000000 0x0>;
+               states = <1800000 0x1>,
+                        <3000000 0x0>;
 
                regulator-min-microvolt = <1800000>;
                regulator-max-microvolt = <3000000>;