ASoC: eukrea-tlv320: fix a leaked reference by adding missing of_node_put
authorWen Yang <wen.yang99@zte.com.cn>
Tue, 26 Feb 2019 08:17:51 +0000 (16:17 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 2 Apr 2019 05:58:26 +0000 (12:58 +0700)
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./sound/soc/fsl/eukrea-tlv320.c:121:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo    nding object release within this function.
./sound/soc/fsl/eukrea-tlv320.c:127:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo    nding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/eukrea-tlv320.c

index 191426a6d9adffa4a4eab4d6f681d3eb1dd101ed..30a3d68b5c0335c2c07a7e87bf049ff8f0de72e4 100644 (file)
@@ -118,13 +118,13 @@ static int eukrea_tlv320_probe(struct platform_device *pdev)
                if (ret) {
                        dev_err(&pdev->dev,
                                "fsl,mux-int-port node missing or invalid.\n");
-                       return ret;
+                       goto err;
                }
                ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port);
                if (ret) {
                        dev_err(&pdev->dev,
                                "fsl,mux-ext-port node missing or invalid.\n");
-                       return ret;
+                       goto err;
                }
 
                /*