spi: Fix condition in the __spi_register_driver()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 Nov 2021 17:00:32 +0000 (19:00 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 24 Nov 2021 12:57:42 +0000 (12:57 +0000)
The recent commit 3f07657506df ("spi: deduplicate spi_match_id()
in __spi_register_driver()") inadvertently inverted a condition
that provokes a (harmless) warning:

  WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45

Restore logic to avoid such warning to be issued.

Fixes: 3f07657506df ("spi: deduplicate spi_match_id() in __spi_register_driver()")
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20211123170034.41253-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c

index 5bf680fcb17098308d21fce9b29f6e68d9634225..8726309b3eaf2844180cc0fadda0f47cedd11d55 100644 (file)
@@ -474,7 +474,7 @@ int __spi_register_driver(struct module *owner, struct spi_driver *sdrv)
                                const struct spi_device_id *spi_id;
 
                                spi_id = spi_match_id(sdrv->id_table, of_name);
-                               if (!spi_id)
+                               if (spi_id)
                                        continue;
                        } else {
                                if (strcmp(sdrv->driver.name, of_name) == 0)