drm/amd/display: correct apg audio channel enable golden value
authorWenjing Liu <wenjing.liu@amd.com>
Tue, 28 Sep 2021 17:09:14 +0000 (13:09 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 19 Oct 2021 21:18:11 +0000 (17:18 -0400)
Hardware team has recommended to generically hard code this register to
0xFF as part of the effort to eventually remove this control.  However
we set it to 0xF instead.
This causes 4 of audio 8ch to be muted.

Reviewed-by: Ariel Bernstein <eric.bernstein@amd.com>
Acked-by: Agustin Gutierrez Sanchez <agustin.gutierrez@amd.com>
Signed-off-by: Wenjing Liu <wenjing.liu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c

index 6bd7a06266659d7ca179cd727db3c4d8e163a1e4..de5e18c2a3ac858bec1397e8e4d9f2295b384ca2 100644 (file)
@@ -129,7 +129,7 @@ static void apg31_se_audio_setup(
 
        /* When running in "pair mode", pairs of audio channels have their own enable
         * this is for really old audio drivers */
-       REG_UPDATE(APG_DBG_GEN_CONTROL, APG_DBG_AUDIO_CHANNEL_ENABLE, 0xF);
+       REG_UPDATE(APG_DBG_GEN_CONTROL, APG_DBG_AUDIO_CHANNEL_ENABLE, 0xFF);
        // REG_UPDATE(APG_DBG_GEN_CONTROL, APG_DBG_AUDIO_CHANNEL_ENABLE, channels);
 
        /* Disable forced mem power off */