bnxt_en: Fix DCB ETS validation
authorShravya KN <shravya.k-n@broadcom.com>
Thu, 10 Jul 2025 21:39:36 +0000 (14:39 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Jul 2025 14:28:34 +0000 (07:28 -0700)
In bnxt_ets_validate(), the code incorrectly loops over all possible
traffic classes to check and add the ETS settings.  Fix it to loop
over the configured traffic classes only.

The unconfigured traffic classes will default to TSA_ETS with 0
bandwidth.  Looping over these unconfigured traffic classes may
cause the validation to fail and trigger this error message:

"rejecting ETS config starving a TC\n"

The .ieee_setets() will then fail.

Fixes: 7df4ae9fe855 ("bnxt_en: Implement DCBNL to support host-based DCBX.")
Reviewed-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: Shravya KN <shravya.k-n@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250710213938.1959625-2-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c

index 0dbb880a7aa0e721f98e42d17f845596a702abc4..71e14be2507e1e52499480bdad72444eee112e15 100644 (file)
@@ -487,7 +487,9 @@ static int bnxt_ets_validate(struct bnxt *bp, struct ieee_ets *ets, u8 *tc)
 
                if ((ets->tc_tx_bw[i] || ets->tc_tsa[i]) && i > bp->max_tc)
                        return -EINVAL;
+       }
 
+       for (i = 0; i < max_tc; i++) {
                switch (ets->tc_tsa[i]) {
                case IEEE_8021QAZ_TSA_STRICT:
                        break;