ARM: dts: sun8i-a83t-tbs-a711: Fix USB OTG mode detection
authorOndrej Jirman <megous@megous.com>
Sat, 22 Feb 2020 22:31:53 +0000 (23:31 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 24 Feb 2020 09:32:25 +0000 (10:32 +0100)
USB-ID signal has a pullup on the schematic, but in reality it's not
pulled up, so add a GPIO pullup. And we also need a usb0_vbus_power-supply
for VBUS detection.

This fixes OTG mode detection and charging issues on TBS A711 tablet.
The issues came from ID pin reading 0, causing host mode to be enabled,
when it should not be, leading to DRVVBUS being enabled, which disabled
the charger.

Fixes: f2f221c7810b824e ("ARM: dts: sun8i: a711: Enable USB OTG")
Signed-off-by: Ondrej Jirman <megous@megous.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts

index eb5e2072a181d78b02e5d18eea13b3d006541697..e8b3669e0e5d8bb5c29cbade1848b89fe50bd3e6 100644 (file)
 };
 
 &usbphy {
-       usb0_id_det-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
+       usb0_id_det-gpios = <&pio 7 11 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH11 */
+       usb0_vbus_power-supply = <&usb_power_supply>;
        usb0_vbus-supply = <&reg_drivevbus>;
        usb1_vbus-supply = <&reg_vmain>;
        usb2_vbus-supply = <&reg_vmain>;