mt76: mt7603: move spin_lock_bh() to spin_lock()
authorYunbo Yu <yuyunbo519@gmail.com>
Mon, 18 Apr 2022 08:18:44 +0000 (16:18 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 13 May 2022 07:39:35 +0000 (09:39 +0200)
It is unnecessary to call spin_lock_bh() within a tasklet.

Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7603/beacon.c

index 5d4522f440b74cf2e5e3be9560d6575fa7b0fbbf..b5e8308e0cc7088a7639e1001ae47b76af71e8fb 100644 (file)
@@ -82,12 +82,12 @@ void mt7603_pre_tbtt_tasklet(struct tasklet_struct *t)
        __skb_queue_head_init(&data.q);
 
        q = dev->mphy.q_tx[MT_TXQ_BEACON];
-       spin_lock_bh(&q->lock);
+       spin_lock(&q->lock);
        ieee80211_iterate_active_interfaces_atomic(mt76_hw(dev),
                IEEE80211_IFACE_ITER_RESUME_ALL,
                mt7603_update_beacon_iter, dev);
        mt76_queue_kick(dev, q);
-       spin_unlock_bh(&q->lock);
+       spin_unlock(&q->lock);
 
        /* Flush all previous CAB queue packets */
        mt76_wr(dev, MT_WF_ARB_CAB_FLUSH, GENMASK(30, 16) | BIT(0));
@@ -117,7 +117,7 @@ void mt7603_pre_tbtt_tasklet(struct tasklet_struct *t)
                mt76_skb_set_moredata(data.tail[i], false);
        }
 
-       spin_lock_bh(&q->lock);
+       spin_lock(&q->lock);
        while ((skb = __skb_dequeue(&data.q)) != NULL) {
                struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
                struct ieee80211_vif *vif = info->control.vif;
@@ -126,7 +126,7 @@ void mt7603_pre_tbtt_tasklet(struct tasklet_struct *t)
                mt76_tx_queue_skb(dev, q, skb, &mvif->sta.wcid, NULL);
        }
        mt76_queue_kick(dev, q);
-       spin_unlock_bh(&q->lock);
+       spin_unlock(&q->lock);
 
        for (i = 0; i < ARRAY_SIZE(data.count); i++)
                mt76_wr(dev, MT_WF_ARB_CAB_COUNT_B0_REG(i),