media: bcm2835-unicam: Fix a NULL vs IS_ERR() check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 8 May 2024 12:31:00 +0000 (15:31 +0300)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 9 May 2024 22:08:09 +0000 (01:08 +0300)
The media_pad_remote_pad_unique() function returns error pointers, not
NULL.  Update the check accordingly.

Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/fbbe7862-2820-44eb-81cb-7f33b99cca35@moroto.mountain
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/media/platform/broadcom/bcm2835-unicam.c

index bdcb04d633380089732ec7a75a7c484a9162464f..a1d93c14553d80e7501fdb583c9b9c537dbc31db 100644 (file)
@@ -2433,9 +2433,9 @@ static int unicam_async_bound(struct v4l2_async_notifier *notifier,
                return ret;
 
        source = media_pad_remote_pad_unique(sink);
-       if (!source) {
+       if (IS_ERR(source)) {
                dev_err(unicam->dev, "No connected sensor pad\n");
-               return -ENOTCONN;
+               return PTR_ERR(source);
        }
 
        unicam->sensor.subdev = subdev;