media: ar0521: fix error return code in ar0521_power_on()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 15 Jul 2022 08:59:24 +0000 (10:59 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sat, 24 Sep 2022 07:03:40 +0000 (09:03 +0200)
Return error code if ar0521_write_regs() fails in ar0521_power_on().

Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Krzysztof HaƂasa <khalasa@piap.pl>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ar0521.c

index c7bdfc69b9be83883b175e28aeb1c106c838060c..e850c92d847e463a7bc8d56947225c0d158a49cd 100644 (file)
@@ -757,8 +757,9 @@ static int ar0521_power_on(struct device *dev)
        usleep_range(4500, 5000); /* min 45000 clocks */
 
        for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++)
-               if (ar0521_write_regs(sensor, initial_regs[cnt].data,
-                                     initial_regs[cnt].count))
+               ret = ar0521_write_regs(sensor, initial_regs[cnt].data,
+                                       initial_regs[cnt].count);
+               if (ret)
                        goto off;
 
        ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT,