drm/amdkfd: remove dead code in kfd_create_vcrat_image_gpu
authorJesse Zhang <jesse.zhang@amd.com>
Thu, 30 May 2024 03:27:28 +0000 (11:27 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 5 Jun 2024 15:25:13 +0000 (11:25 -0400)
kfd_create_vcrat_image_gpu itself checks the avail_size at the start.
So the value of avail_size is at least VCRAT_SIZE_FOR_GPU(16384),
minus struct crat_header(40UL) and struct crat_subtype_compute(40UL) it cannot be less than 0.

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_crat.c

index 71150d503dc73c1c0a654a9867a97d5e5bc1260d..ead43386a7ef559f3ec021e544a234579082ebeb 100644 (file)
@@ -2213,9 +2213,6 @@ static int kfd_create_vcrat_image_gpu(void *pcrat_image,
         * Modify length and total_entries as subunits are added.
         */
        avail_size -= sizeof(struct crat_header);
-       if (avail_size < 0)
-               return -ENOMEM;
-
        memset(crat_table, 0, sizeof(struct crat_header));
 
        memcpy(&crat_table->signature, CRAT_SIGNATURE,
@@ -2229,9 +2226,6 @@ static int kfd_create_vcrat_image_gpu(void *pcrat_image,
         * First fill in the sub type header and then sub type data
         */
        avail_size -= sizeof(struct crat_subtype_computeunit);
-       if (avail_size < 0)
-               return -ENOMEM;
-
        sub_type_hdr = (struct crat_subtype_generic *)(crat_table + 1);
        memset(sub_type_hdr, 0, sizeof(struct crat_subtype_computeunit));