staging: greybus: audio_manager: fix a missing check of ida_simple_get

ida_simple_get could fail. The fix inserts a check for its
return value.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
index d44b070d886262998b6a70f71ae2a4b6df666fe4..c2a4af4c1d0662465cd69cf2032cdffb56b19334 100644 (file)
--- a/drivers/staging/greybus/audio_manager.c
+++ b/drivers/staging/greybus/audio_manager.c
@@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
        int err;
 
        id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
+       if (id < 0)
+               return id;
+
        err = gb_audio_manager_module_create(&module, manager_kset,
                                             id, desc);
        if (err) {