hwmon: (corsair-psu) various cleanups

Fix some typos, adjust documentation and comments to current state of
knowledge and update coding style to be more uniform.

Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
Link: https://lore.kernel.org/r/ZJWf3H972hGgLK-8@monster.localdomain
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/Documentation/hwmon/corsair-psu.rst b/Documentation/hwmon/corsair-psu.rst
index fc798c3df1d05dbc27b88338ba16d35cf82c282a..47f8ff6322677de79ad21bb06b0f65fb8d10e1cf 100644 (file)
--- a/Documentation/hwmon/corsair-psu.rst
+++ b/Documentation/hwmon/corsair-psu.rst
@@ -15,11 +15,11 @@ Supported devices:
 
   Corsair HX850i
 
-  Corsair HX1000i (revision 1 and 2)
+  Corsair HX1000i (Series 2022 and Series 2023)
 
   Corsair HX1200i
 
-  Corsair HX1500i
+  Corsair HX1500i (Series 2022)
 
   Corsair RM550i
 

diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
index 2389f605ca1650ed42e7633960b06ffa04375da1..9e3e3c0a3bdd62389baf832eef96c24f9aab1b3c 100644 (file)
--- a/drivers/hwmon/corsair-psu.c
+++ b/drivers/hwmon/corsair-psu.c
@@ -32,18 +32,17 @@
  *       but it is better to not rely on this (it is also hard to parse)
  *     - the driver uses raw events to be accessible from userspace (though this is not really
  *       supported, it is just there for convenience, may be removed in the future)
- *     - a reply always start with the length and command in the same order the request used it
+ *     - a reply always starts with the length and command in the same order the request used it
  *     - length of the reply data is specific to the command used
  *     - some of the commands work on a rail and can be switched to a specific rail (0 = 12v,
  *       1 = 5v, 2 = 3.3v)
  *     - the format of the init command 0xFE is swapped length/command bytes
  *     - parameter bytes amount and values are specific to the command (rail setting is the only
- *       for now that uses non-zero values)
- *     - there are much more commands, especially for configuring the device, but they are not
- *       supported because a wrong command/length can lockup the micro-controller
+ *       one for now that uses non-zero values)
  *     - the driver supports debugfs for values not fitting into the hwmon class
- *     - not every device class (HXi, RMi or AXi) supports all commands
- *     - it is a pure sensors reading driver (will not support configuring)
+ *     - not every device class (HXi or RMi) supports all commands
+ *     - if configured wrong the PSU resets or shuts down, often before actually hitting the
+ *     - reported critical temperature
  */
 
 #define DRIVER_NAME            "corsair-psu"
@@ -254,8 +253,8 @@ static int corsairpsu_get_value(struct corsairpsu_data *priv, u8 cmd, u8 rail, l
        /*
         * the biggest value here comes from the uptime command and to exceed MAXINT total uptime
         * needs to be about 68 years, the rest are u16 values and the biggest value coming out of
-        * the LINEAR11 conversion are the watts values which are about 1200 for the strongest psu
-        * supported (HX1200i)
+        * the LINEAR11 conversion are the watts values which are about 1500 for the strongest psu
+        * supported (HX1500i)
         */
        tmp = ((long)data[3] << 24) + (data[2] << 16) + (data[1] << 8) + data[0];
        switch (cmd) {
@@ -629,7 +628,7 @@ static const struct hwmon_ops corsairpsu_hwmon_ops = {
        .read_string    = corsairpsu_hwmon_ops_read_string,
 };
 
-static const struct hwmon_channel_info * const corsairpsu_info[] = {
+static const struct hwmon_channel_info *const corsairpsu_info[] = {
        HWMON_CHANNEL_INFO(chip,
                           HWMON_C_REGISTER_TZ),
        HWMON_CHANNEL_INFO(temp,
@@ -873,15 +872,15 @@ static const struct hid_device_id corsairpsu_idtable[] = {
        { HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */
        { HID_USB_DEVICE(0x1b1c, 0x1c05) }, /* Corsair HX750i */
        { HID_USB_DEVICE(0x1b1c, 0x1c06) }, /* Corsair HX850i */
-       { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i revision 1 */
+       { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i Series 2022 */
        { HID_USB_DEVICE(0x1b1c, 0x1c08) }, /* Corsair HX1200i */
        { HID_USB_DEVICE(0x1b1c, 0x1c09) }, /* Corsair RM550i */
        { HID_USB_DEVICE(0x1b1c, 0x1c0a) }, /* Corsair RM650i */
        { HID_USB_DEVICE(0x1b1c, 0x1c0b) }, /* Corsair RM750i */
        { HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */
        { HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */
-       { HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsair HX1000i revision 2 */
-       { HID_USB_DEVICE(0x1b1c, 0x1c1f) }, /* Corsair HX1500i */
+       { HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsair HX1000i Series 2023 */
+       { HID_USB_DEVICE(0x1b1c, 0x1c1f) }, /* Corsair HX1500i Series 2022 */
        { },
 };
 MODULE_DEVICE_TABLE(hid, corsairpsu_idtable);