KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2...
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 28 Jan 2024 11:34:25 +0000 (12:34 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 7 May 2024 15:28:00 +0000 (01:28 +1000)
The return value of kvmppc_gse_put_buff_info() is not assigned to 'rc' and
'rc' is uninitialized at this point.
So the error handling can not work.

Assign the expected value to 'rc' to fix the issue.

Fixes: 19d31c5f1157 ("KVM: PPC: Add support for nestedv2 guests")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/a7ed4cc12e0a0bbd97fac44fe6c222d1c393ec95.1706441651.git.christophe.jaillet@wanadoo.fr
arch/powerpc/kvm/book3s_hv_nestedv2.c

index 8e6f5355f08b5d925c54606db4a70cbe24d74e61..1091f7a83b255d0b13320557afcf55937632c682 100644 (file)
@@ -71,8 +71,8 @@ gs_msg_ops_kvmhv_nestedv2_config_fill_info(struct kvmppc_gs_buff *gsb,
        }
 
        if (kvmppc_gsm_includes(gsm, KVMPPC_GSID_RUN_OUTPUT)) {
-               kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
-                                        cfg->vcpu_run_output_cfg);
+               rc = kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
+                                             cfg->vcpu_run_output_cfg);
                if (rc < 0)
                        return rc;
        }