powerpc/64s/idle: Branch to handler with virtual mode offset
authorNicholas Piggin <npiggin@gmail.com>
Tue, 13 Jun 2017 13:05:50 +0000 (23:05 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 19 Jun 2017 09:46:28 +0000 (19:46 +1000)
Have the system reset idle wakeup handlers branched to in real mode
with the 0xc... kernel address applied. This allows simplifications of
avoiding rfid when switching to virtual mode in the wakeup handler.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/exception-64s.h
arch/powerpc/kernel/exceptions-64s.S

index 183d73b6ed99f464801603573661aa4488fba3e9..33473cbc098649939442999a7c210346548c6ef5 100644 (file)
@@ -236,6 +236,19 @@ END_FTR_SECTION_NESTED(ftr,ftr,943)
 #define kvmppc_interrupt kvmppc_interrupt_pr
 #endif
 
+/*
+ * Branch to label using its 0xC000 address. This results in instruction
+ * address suitable for MSR[IR]=0 or 1, which allows relocation to be turned
+ * on using mtmsr rather than rfid.
+ *
+ * This could set the 0xc bits for !RELOCATABLE as an immediate, rather than
+ * load KBASE for a slight optimisation.
+ */
+#define BRANCH_TO_C000(reg, label)                                     \
+       __LOAD_HANDLER(reg, label);                                     \
+       mtctr   reg;                                                    \
+       bctr
+
 #ifdef CONFIG_RELOCATABLE
 #define BRANCH_TO_COMMON(reg, label)                                   \
        __LOAD_HANDLER(reg, label);                                     \
index cad3b4b8281309613319a0604df688cad93a5917..7807719ca855e4add10c341a71a2bc573bde269e 100644 (file)
@@ -99,7 +99,9 @@ EXC_VIRT_NONE(0x4000, 0x100)
 #ifdef CONFIG_PPC_P7_NAP
        /*
         * If running native on arch 2.06 or later, check if we are waking up
-        * from nap/sleep/winkle, and branch to idle handler.
+        * from nap/sleep/winkle, and branch to idle handler. The idle wakeup
+        * handler initially runs in real mode, but we branch to the 0xc000...
+        * address so we can turn on relocation with mtmsr.
         */
 #define IDLETEST(n)                                                    \
        BEGIN_FTR_SECTION ;                                             \
@@ -107,7 +109,7 @@ EXC_VIRT_NONE(0x4000, 0x100)
        rlwinm. r10,r10,47-31,30,31 ;                                   \
        beq-    1f ;                                                    \
        cmpwi   cr3,r10,2 ;                                             \
-       BRANCH_TO_COMMON(r10, system_reset_idle_common) ;               \
+       BRANCH_TO_C000(r10, system_reset_idle_common) ;                 \
 1:                                                                     \
        END_FTR_SECTION_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206)
 #else