selftests: firmware: Fix ignored return val of asprintf() warn
authorShuah Khan <skhan@linuxfoundation.org>
Thu, 8 Jul 2021 03:18:27 +0000 (21:18 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:40:20 +0000 (13:40 +0200)
[ Upstream commit fe968ca2cac91888310b143a483123c84906e3fc ]

Fix the following ingonred return val of asprintf() warn during
build:

cc -Wall -O2    fw_namespace.c  -o ../tools/testing/selftests/firmware/fw_namespace
fw_namespace.c: In function ‘main’:
fw_namespace.c:132:2: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  132 |  asprintf(&fw_path, "/lib/firmware/%s", fw_name);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20210708031827.51293-1-skhan@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/firmware/fw_namespace.c

index 5ebc1aec7923b41b3d8697957883d1c358ffd53d..817b2f1e8ee6a396546d5e9506658918ef3f44c4 100644 (file)
@@ -129,7 +129,8 @@ int main(int argc, char **argv)
                die("mounting tmpfs to /lib/firmware failed\n");
 
        sys_path = argv[1];
-       asprintf(&fw_path, "/lib/firmware/%s", fw_name);
+       if (asprintf(&fw_path, "/lib/firmware/%s", fw_name) < 0)
+               die("error: failed to build full fw_path\n");
 
        setup_fw(fw_path);