net: caif: use max() to simplify the code
authorLi Zetao <lizetao1@huawei.com>
Thu, 22 Aug 2024 13:39:03 +0000 (21:39 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 26 Aug 2024 16:48:53 +0000 (09:48 -0700)
When processing the tail append of sk buffer, the final length needs
to be determined based on expectlen and addlen. Using max() here can
increase the readability of the code.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240822133908.1042240-4-lizetao1@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/caif/cfpkt_skbuff.c

index 2ae8cfa3df8845dc85ee28619740c7e8fc9743ea..96236d21b18e5cabc75e493927f11c77dc04a783 100644 (file)
@@ -298,10 +298,8 @@ struct cfpkt *cfpkt_append(struct cfpkt *dstpkt,
        if (unlikely(is_erronous(dstpkt) || is_erronous(addpkt))) {
                return dstpkt;
        }
-       if (expectlen > addlen)
-               neededtailspace = expectlen;
-       else
-               neededtailspace = addlen;
+
+       neededtailspace = max(expectlen, addlen);
 
        if (dst->tail + neededtailspace > dst->end) {
                /* Create a dumplicate of 'dst' with more tail space */