gpu: host1x: remove redundant assignment to variable space
authorColin Ian King <colin.i.king@gmail.com>
Thu, 15 Feb 2024 22:43:01 +0000 (22:43 +0000)
committerThierry Reding <treding@nvidia.com>
Fri, 16 Feb 2024 10:51:46 +0000 (11:51 +0100)
The variable space is being initialized with a value that is never read,
it is being re-assigned later on. The initialization is redundant and
can be removed. Also merge two declaration lines together.

Cleans up clang scan build warning:
drivers/gpu/host1x/cdma.c:628:15: warning: Value stored to 'space'
during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240215224301.2073845-1-colin.i.king@gmail.com
drivers/gpu/host1x/cdma.c

index d1336e438f4f1f36a47cc049ed6bdecf786a411f..407ed9b9cf642007064f8b99eed22dbcdb04fc51 100644 (file)
@@ -625,8 +625,7 @@ void host1x_cdma_push_wide(struct host1x_cdma *cdma, u32 op1, u32 op2,
        struct host1x_channel *channel = cdma_to_channel(cdma);
        struct host1x *host1x = cdma_to_host1x(cdma);
        struct push_buffer *pb = &cdma->push_buffer;
-       unsigned int space = cdma->slots_free;
-       unsigned int needed = 2, extra = 0;
+       unsigned int space, needed = 2, extra = 0;
 
        if (host1x_debug_trace_cmdbuf)
                trace_host1x_cdma_push_wide(dev_name(channel->dev), op1, op2,