staging: rtl8723bs: Remove function pointer run_thread
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Tue, 5 Nov 2024 05:54:56 +0000 (06:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Nov 2024 08:29:50 +0000 (09:29 +0100)
Remove function pointer run_thread and use rtl8723b_start_thread
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/aee978f7180d728517af457e525549c19e3618c8.1730749680.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/hal_intf.c
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
drivers/staging/rtl8723bs/include/hal_intf.h

index 46da566106ae2212f60902e98c4b3523bb3fd976..28d15536abbb736291204b13619effc895af21cd 100644 (file)
@@ -233,8 +233,7 @@ void rtw_hal_add_ra_tid(struct adapter *padapter, u32 bitmap, u8 *arg, u8 rssi_l
 /*Start specifical interface thread            */
 void rtw_hal_start_thread(struct adapter *padapter)
 {
-       if (padapter->HalFunc.run_thread)
-               padapter->HalFunc.run_thread(padapter);
+       rtl8723b_start_thread(padapter);
 }
 /*Start specifical interface thread            */
 void rtw_hal_stop_thread(struct adapter *padapter)
index 66c2a8fb24545b68102c6fa94965e116c12733d9..8d8270d85f960cb2d209bd168396aaee74ec3f6e 100644 (file)
@@ -1744,7 +1744,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
 
 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
 {
-       pHalFunc->run_thread = &rtl8723b_start_thread;
        pHalFunc->cancel_thread = &rtl8723b_stop_thread;
 
        pHalFunc->read_bbreg = &PHY_QueryBBReg_8723B;
index dc5bb61294b03b4ce6a2a9807811dba87ec96651..3306c26ed2a4aae84d53308d872507f264634c7e 100644 (file)
@@ -164,7 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
 struct hal_ops {
        void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
 
-       void (*run_thread)(struct adapter *padapter);
        void (*cancel_thread)(struct adapter *padapter);
 
        u32 (*read_bbreg)(struct adapter *padapter, u32 RegAddr, u32 BitMask);