media: au8522: remove duplicate code
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 22 May 2018 17:09:22 +0000 (13:09 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 28 May 2018 20:26:38 +0000 (16:26 -0400)
This code has been there for nine years now, and it has been
working "good enough" since then [1].

Remove duplicate code by getting rid of the if-else statement.

[1] https://marc.info/?l=linux-kernel&m=152693550225081&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/au8522_decoder.c

index 343dc92ef54e95034e037b1720a183645fd6d04b..f285096a48f08d361e7bc587ca8f471e3a43b009 100644 (file)
@@ -280,14 +280,12 @@ static void setup_decoder_defaults(struct au8522_state *state, bool is_svideo)
                        AU8522_TOREGAAGC_REG0E5H_CVBS);
        au8522_writereg(state, AU8522_REG016H, AU8522_REG016H_CVBS);
 
-       if (is_svideo) {
-               /* Despite what the table says, for the HVR-950q we still need
-                  to be in CVBS mode for the S-Video input (reason unknown). */
-               /* filter_coef_type = 3; */
-               filter_coef_type = 5;
-       } else {
-               filter_coef_type = 5;
-       }
+       /*
+        * Despite what the table says, for the HVR-950q we still need
+        * to be in CVBS mode for the S-Video input (reason unknown).
+        */
+       /* filter_coef_type = 3; */
+       filter_coef_type = 5;
 
        /* Load the Video Decoder Filter Coefficients */
        for (i = 0; i < NUM_FILTER_COEF; i++) {