RDMA/rtrs: Do not signal for heatbeat

For HB, there is no need to generate signal for completion.

Also remove a comment accordingly.

Fixes: c0894b3ea69d ("RDMA/rtrs: core: lib functions shared between client and server modules")
Link: https://lore.kernel.org/r/20201217141915.56989-16-jinpu.wang@cloud.ionos.com
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Reported-by: Gioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index 493f45a33b5e8b1a291dfa3421afd4b0ff53c41e..2053bf99418af14a70131629114a638bead3a945 100644 (file)
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -664,7 +664,6 @@ static void rtrs_clt_rdma_done(struct ib_cq *cq, struct ib_wc *wc)
        case IB_WC_RDMA_WRITE:
                /*
                 * post_send() RDMA write completions of IO reqs (read/write)
-                * and hb
                 */
                break;
 

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
index f59731c5a96a3ac4bddec9abe35d0fec33ffbb07..de2d5b742c397c6a3a2a0a640af27f65583ac260 100644 (file)
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
@@ -1242,7 +1242,6 @@ static void rtrs_srv_rdma_done(struct ib_cq *cq, struct ib_wc *wc)
        case IB_WC_SEND:
                /*
                 * post_send() RDMA write completions of IO reqs (read/write)
-                * and hb
                 */
                atomic_add(srv->queue_depth, &con->sq_wr_avail);
 

diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c b/drivers/infiniband/ulp/rtrs/rtrs.c
index df52427f17106de059d200587c15ae324e3e1cd8..97af8f0bb806588408960c66ce34401d73573bee 100644 (file)
--- a/drivers/infiniband/ulp/rtrs/rtrs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs.c
@@ -310,7 +310,7 @@ void rtrs_send_hb_ack(struct rtrs_sess *sess)
 
        imm = rtrs_to_imm(RTRS_HB_ACK_IMM, 0);
        err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm,
-                                             IB_SEND_SIGNALED, NULL);
+                                            0, NULL);
        if (err) {
                sess->hb_err_handler(usr_con);
                return;
@@ -339,7 +339,7 @@ static void hb_work(struct work_struct *work)
        }
        imm = rtrs_to_imm(RTRS_HB_MSG_IMM, 0);
        err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm,
-                                             IB_SEND_SIGNALED, NULL);
+                                            0, NULL);
        if (err) {
                sess->hb_err_handler(usr_con);
                return;