ice: suppress false cppcheck issues

Silence false errors, warnings and style issues reported by cppcheck.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
index 4b83960876f4a86df6d370dca73c2a1e398c6390..06ac9badee7748e57a99e14a075fec85f1f5e8a6 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
@@ -334,6 +334,7 @@ ice_boost_tcam_handler(u32 sect_type, void *section, u32 index, u32 *offset)
        if (sect_type != ICE_SID_RXPARSER_BOOST_TCAM)
                return NULL;
 
+       /* cppcheck-suppress nullPointer */
        if (index > ICE_MAX_BST_TCAMS_IN_BUF)
                return NULL;
 
@@ -404,6 +405,7 @@ ice_label_enum_handler(u32 __always_unused sect_type, void *section, u32 index,
        if (!section)
                return NULL;
 
+       /* cppcheck-suppress nullPointer */
        if (index > ICE_MAX_LABELS_IN_BUF)
                return NULL;
 
@@ -2067,6 +2069,7 @@ ice_match_prop_lst(struct list_head *list1, struct list_head *list2)
                count++;
        list_for_each_entry(tmp2, list2, list)
                chk_count++;
+       /* cppcheck-suppress knownConditionTrueFalse */
        if (!count || count != chk_count)
                return false;
 

diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c b/drivers/net/ethernet/intel/ice/ice_nvm.c
index 75ccbfc07f99a1eb7a08da535b130a2d47e35efe..fee37a5844cfb8d489057dc0ff8e31bf46e28579 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_nvm.c
+++ b/drivers/net/ethernet/intel/ice/ice_nvm.c
@@ -644,6 +644,7 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum ice_bank_select bank,
 
                /* Verify that the simple checksum is zero */
                for (i = 0; i < sizeof(tmp); i++)
+                       /* cppcheck-suppress objectIndex */
                        sum += ((u8 *)&tmp)[i];
 
                if (sum) {

diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c
index 97562051fe14f0f947fe17ed06708a071c4b22d6..2f097637e405135ec6e60b3b0e0f3e4c93e53431 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_sched.c
+++ b/drivers/net/ethernet/intel/ice/ice_sched.c
@@ -988,6 +988,7 @@ ice_sched_add_nodes_to_layer(struct ice_port_info *pi,
        *num_nodes_added = 0;
        while (*num_nodes_added < num_nodes) {
                u16 max_child_nodes, num_added = 0;
+               /* cppcheck-suppress unusedVariable */
                u32 temp;
 
                status = ice_sched_add_nodes_to_hw_layer(pi, tc_node, parent,