drm/amdgpu: only set restart on first cmd of the smu i2c transaction

Not sure how the firmware interprets these.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
index 2cc6c65f45b473f281737a39e31988b11dd7b5ec..945e25df9165442315da130983502c5d3a6442ad 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
@@ -1984,7 +1984,7 @@ static int arcturus_i2c_xfer(struct i2c_adapter *i2c_adap,
                        if ((msg[i].flags & I2C_M_STOP) ||
                            (!remaining_bytes))
                                cmd->CmdConfig |= CMDCONFIG_STOP_MASK;
-                       if ((i > 0) && !(msg[i].flags & I2C_M_NOSTART))
+                       if ((i > 0) && (j == 0) && !(msg[i].flags & I2C_M_NOSTART))
                                cmd->CmdConfig |= CMDCONFIG_RESTART_BIT;
                }
        }

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
index 049d05de08dcba5f2004cf1cf35f1ec866e0d30e..b6a2393e346b26ba890e9d28561cb4feadf37193 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
@@ -2783,7 +2783,7 @@ static int navi10_i2c_xfer(struct i2c_adapter *i2c_adap,
                        if ((msg[i].flags & I2C_M_STOP) ||
                            (!remaining_bytes))
                                cmd->CmdConfig |= CMDCONFIG_STOP_MASK;
-                       if ((i > 0) && !(msg[i].flags & I2C_M_NOSTART))
+                       if ((i > 0) && (j == 0) && !(msg[i].flags & I2C_M_NOSTART))
                                cmd->CmdConfig |= CMDCONFIG_RESTART_BIT;
                }
        }

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index 1d06641ad87890ab2a470c52f7ebd644f2dc6ca8..9e49505a6ac109e74b6c141f0770c43f75df245a 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -3490,7 +3490,7 @@ static int sienna_cichlid_i2c_xfer(struct i2c_adapter *i2c_adap,
                        if ((msg[i].flags & I2C_M_STOP) ||
                            (!remaining_bytes))
                                cmd->CmdConfig |= CMDCONFIG_STOP_MASK;
-                       if ((i > 0) && !(msg[i].flags & I2C_M_NOSTART))
+                       if ((i > 0) && (j == 0) && !(msg[i].flags & I2C_M_NOSTART))
                                cmd->CmdConfig |= CMDCONFIG_RESTART_BIT;
                }
        }