iomap: make buffered writes work with RWF_DONTCACHE
authorJens Axboe <axboe@kernel.dk>
Tue, 4 Feb 2025 18:39:59 +0000 (11:39 -0700)
committerChristian Brauner <brauner@kernel.org>
Thu, 27 Feb 2025 10:27:54 +0000 (11:27 +0100)
Add iomap buffered write support for RWF_DONTCACHE. If RWF_DONTCACHE is
set for a write, mark the folios being written as uncached. Then
writeback completion will drop the pages. The write_iter handler simply
kicks off writeback for the pages, and writeback completion will take
care of the rest.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Link: https://lore.kernel.org/r/20250204184047.356762-2-axboe@kernel.dk
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Documentation/filesystems/iomap/design.rst
Documentation/filesystems/iomap/operations.rst
fs/iomap/buffered-io.c
include/linux/iomap.h

index b0d0188a095e55a869bd293f2a5b9cf19162baf3..7b91546750f59e742cda02ed50ddade75d429fa1 100644 (file)
@@ -352,6 +352,11 @@ operations:
    ``IOMAP_NOWAIT`` is often set on behalf of ``IOCB_NOWAIT`` or
    ``RWF_NOWAIT``.
 
+ * ``IOMAP_DONTCACHE`` is set when the caller wishes to perform a
+   buffered file I/O and would like the kernel to drop the pagecache
+   after the I/O completes, if it isn't already being used by another
+   thread.
+
 If it is necessary to read existing file contents from a `different
 <https://lore.kernel.org/all/20191008071527.29304-9-hch@lst.de/>`_
 device or address range on a device, the filesystem should return that
index 2c7f5df9d8b037c887727a74988a2a3cf574d723..584ff549f9a659fd1ffbb084e0d8e9d8ae510f3c 100644 (file)
@@ -131,6 +131,8 @@ These ``struct kiocb`` flags are significant for buffered I/O with iomap:
 
  * ``IOCB_NOWAIT``: Turns on ``IOMAP_NOWAIT``.
 
+ * ``IOCB_DONTCACHE``: Turns on ``IOMAP_DONTCACHE``.
+
 Internal per-Folio State
 ------------------------
 
index d303e6c8900cd1eba296b34a94849954b40d46cc..ea863c3cf51018f7dc3b348abbacf92ebbeddc15 100644 (file)
@@ -603,6 +603,8 @@ struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len)
 
        if (iter->flags & IOMAP_NOWAIT)
                fgp |= FGP_NOWAIT;
+       if (iter->flags & IOMAP_DONTCACHE)
+               fgp |= FGP_DONTCACHE;
        fgp |= fgf_set_order(len);
 
        return __filemap_get_folio(iter->inode->i_mapping, pos >> PAGE_SHIFT,
@@ -1034,6 +1036,8 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i,
 
        if (iocb->ki_flags & IOCB_NOWAIT)
                iter.flags |= IOMAP_NOWAIT;
+       if (iocb->ki_flags & IOCB_DONTCACHE)
+               iter.flags |= IOMAP_DONTCACHE;
 
        while ((ret = iomap_iter(&iter, ops)) > 0)
                iter.processed = iomap_write_iter(&iter, i);
index 75bf54e76f3b85ee0b903eda30a66b957ca0f64a..26b0dbe23e62f6af946a1a2a0d8531adc1ccb825 100644 (file)
@@ -183,6 +183,7 @@ struct iomap_folio_ops {
 #define IOMAP_DAX              0
 #endif /* CONFIG_FS_DAX */
 #define IOMAP_ATOMIC           (1 << 9)
+#define IOMAP_DONTCACHE                (1 << 10)
 
 struct iomap_ops {
        /*