Btrfs: add missing brelse when superblock checksum fails
authorAnand Jain <anand.jain@oracle.com>
Wed, 7 Oct 2015 09:23:23 +0000 (17:23 +0800)
committerDavid Sterba <dsterba@suse.com>
Thu, 7 Jan 2016 13:26:53 +0000 (14:26 +0100)
Looks like oversight, call brelse() when checksum fails. Further down the
code, in the non error path, we do call brelse() and so we don't see
brelse() in the goto error paths.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c

index 974be09e7556ca3f342cac89357364f4ce3cc016..216f97765b565a157634cd78ec396a45db9408a8 100644 (file)
@@ -2668,6 +2668,7 @@ int open_ctree(struct super_block *sb,
        if (btrfs_check_super_csum(bh->b_data)) {
                printk(KERN_ERR "BTRFS: superblock checksum mismatch\n");
                err = -EINVAL;
+               brelse(bh);
                goto fail_alloc;
        }