net: ethernet: mediatek: remove return value check of `mtk_wed_hw_add_debugfs`
authorWang Zhang <silver_code@hust.edu.cn>
Fri, 21 Apr 2023 15:10:09 +0000 (23:10 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 23 Apr 2023 12:37:27 +0000 (13:37 +0100)
Smatch complains that:
mtk_wed_hw_add_debugfs() warn: 'dir' is an error pointer or valid

Debugfs checks are generally not supposed to be checked
for errors and it is not necessary here.

fix it by just deleting the dead code.

Signed-off-by: Wang Zhang <silver_code@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_wed_debugfs.c

index 56f6634397214839e5868c022352ab7323329602..b244c02c5b511e04f15bacbe0b72bac523d96bfd 100644 (file)
@@ -252,8 +252,6 @@ void mtk_wed_hw_add_debugfs(struct mtk_wed_hw *hw)
 
        snprintf(hw->dirname, sizeof(hw->dirname), "wed%d", hw->index);
        dir = debugfs_create_dir(hw->dirname, NULL);
-       if (!dir)
-               return;
 
        hw->debugfs_dir = dir;
        debugfs_create_u32("regidx", 0600, dir, &hw->debugfs_reg);