xfs: remove the unusued tmp_logflags variable in xfs_bmapi_allocate
authorChristoph Hellwig <hch@lst.de>
Mon, 29 Apr 2024 06:15:22 +0000 (08:15 +0200)
committerChandan Babu R <chandanbabu@kernel.org>
Tue, 30 Apr 2024 04:15:19 +0000 (09:45 +0530)
tmp_logflags is initialized to 0 and then ORed into bma->logflags, which
isn't actually doing anything.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/libxfs/xfs_bmap.c

index 14c9781ec0ce75e59c99feacca8e805954d96199..d59fc8107d6956c89e9e5f4671cbd0f8a7d58a55 100644 (file)
@@ -4182,7 +4182,6 @@ xfs_bmapi_allocate(
        struct xfs_mount        *mp = bma->ip->i_mount;
        int                     whichfork = xfs_bmapi_whichfork(bma->flags);
        struct xfs_ifork        *ifp = xfs_ifork_ptr(bma->ip, whichfork);
-       int                     tmp_logflags = 0;
        int                     error;
 
        ASSERT(bma->length > 0);
@@ -4253,8 +4252,6 @@ xfs_bmapi_allocate(
                error = xfs_bmap_add_extent_hole_real(bma->tp, bma->ip,
                                whichfork, &bma->icur, &bma->cur, &bma->got,
                                &bma->logflags, bma->flags);
-
-       bma->logflags |= tmp_logflags;
        if (error)
                return error;