media: staging: atomisp: remove redundant assignments to various variables

There are various assignments that are being made to variables that are
not read and the variables are being updated later on, hence the redundant
assignments can be removed.

Cleans up clang warnings:
drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c:1950:8:
warning: Value stored to 'pdata' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:1853:29:
warning: Value stored to 'asd' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:4505:29:
warning: Value stored to 'asd' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c:1139:30:
warning: Value stored to 'asd' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c:6961:27:
warning: Value stored to 'tmp_in_info' during its initialization is
never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c
index 56f3cd0d8c231f58ae4ec8de1821fae771364fde..30a735e59e548f673386453404272c296a903ab5 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c
+++ b/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c
@@ -1893,7 +1893,7 @@ static int ov5693_probe(struct i2c_client *client)
        struct ov5693_device *dev;
        int i2c;
        int ret = 0;
-       void *pdata = client->dev.platform_data;
+       void *pdata;
        unsigned int i;
 
        /*

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 3410a7fb1fcf62432a611db1770706818b2fcb98..22f2dbcecc150c162ce58edf22c59ec7abef3a34 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -1850,7 +1850,7 @@ irqreturn_t atomisp_isr_thread(int irq, void *isp_ptr)
        bool frame_done_found[MAX_STREAM_NUM] = {0};
        bool css_pipe_done[MAX_STREAM_NUM] = {0};
        unsigned int i;
-       struct atomisp_sub_device *asd = &isp->asd[0];
+       struct atomisp_sub_device *asd;
 
        dev_dbg(isp->dev, ">%s\n", __func__);
 

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
index b7f9da014641c14f91d24b84750c76cb4b843d01..7621b45371472bc70ef756ca2810e14795740b6e 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
@@ -4502,7 +4502,7 @@ int atomisp_css_isr_thread(struct atomisp_device *isp,
 {
        enum atomisp_input_stream_id stream_id = 0;
        struct atomisp_css_event current_event;
-       struct atomisp_sub_device *asd = &isp->asd[0];
+       struct atomisp_sub_device *asd;
 #ifndef ISP2401
        bool reset_wdt_timer[MAX_STREAM_NUM] = {false};
 #endif

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
index 548e00e7d67b643bc518d5a7b18332fa4bdf7ec2..ba20344ec56060fda76d3e062741b9f1ba0a343b 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
@@ -1137,7 +1137,6 @@ static int init_atomisp_wdts(struct atomisp_device *isp)
 
        for (i = 0; i < isp->num_of_streams; i++) {
                struct atomisp_sub_device *asd = &isp->asd[i];
-               asd = &isp->asd[i];
 #ifndef ISP2401
                timer_setup(&asd->wdt, atomisp_wdt, 0);
 #else

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
index de712fa54b2641720c5645d8b10e731279c7d40b..dc6225c491004a8504c8ba08a3702a928fb91f04 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
@@ -6958,7 +6958,7 @@ static enum ia_css_err ia_css_pipe_create_cas_scaler_desc_single_output(
        unsigned int i;
        unsigned int hor_ds_factor = 0, ver_ds_factor = 0;
        enum ia_css_err err = IA_CSS_SUCCESS;
-       struct ia_css_frame_info tmp_in_info = IA_CSS_BINARY_DEFAULT_FRAME_INFO;
+       struct ia_css_frame_info tmp_in_info;
 
        unsigned max_scale_factor_per_stage = MAX_PREFERRED_YUV_DS_PER_STEP;