ASoC: tas2770: Fix calling reset in probe
authorDan Murphy <dmurphy@ti.com>
Fri, 18 Sep 2020 19:05:40 +0000 (14:05 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 21 Sep 2020 19:40:52 +0000 (20:40 +0100)
tas2770_reset is called during i2c probe. The reset calls the
snd_soc_component_write which depends on the tas2770->component being
available. The component pointer is not set until codec_probe so move
the reset to the codec_probe after the pointer is set.

Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Link: https://lore.kernel.org/r/20200918190548.12598-1-dmurphy@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2770.c

index c098518343959cbbb36c427d4396a5d4fd8c9146..03d7ad1885b819cde884565183d1f995cbb66589 100644 (file)
@@ -575,6 +575,8 @@ static int tas2770_codec_probe(struct snd_soc_component *component)
 
        tas2770->component = component;
 
+       tas2770_reset(tas2770);
+
        return 0;
 }
 
@@ -771,8 +773,6 @@ static int tas2770_i2c_probe(struct i2c_client *client,
        tas2770->channel_size = 0;
        tas2770->slot_width = 0;
 
-       tas2770_reset(tas2770);
-
        result = tas2770_register_codec(tas2770);
        if (result)
                dev_err(tas2770->dev, "Register codec failed.\n");