PCI/ERR: Remove misleading TODO regarding kernel panic
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thu, 8 May 2025 07:10:30 +0000 (12:40 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 30 May 2025 17:21:19 +0000 (12:21 -0500)
A PCI device is just another peripheral in a system. So failure to
recover it, must not result in a kernel panic. So remove the TODO which
is quite misleading.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Link: https://patch.msgid.link/20250508-pcie-reset-slot-v4-1-7050093e2b50@linaro.org
drivers/pci/pcie/err.c

index 31090770fffcc94e15ba6e89f649c6f84bfdf0d5..de6381c690f5c21f00021cdc7bde8d93a5c7db52 100644 (file)
@@ -271,7 +271,6 @@ failed:
 
        pci_uevent_ers(bridge, PCI_ERS_RESULT_DISCONNECT);
 
-       /* TODO: Should kernel panic here? */
        pci_info(bridge, "device recovery failed\n");
 
        return status;