scsi: ufs: Remove redundant null checking of devfreq instance
authorStanley Chu <stanley.chu@mediatek.com>
Wed, 20 Jan 2021 15:01:41 +0000 (23:01 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 21 Jan 2021 03:29:38 +0000 (22:29 -0500)
hba->devfreq is zero-initialized thus it is not required to check its
existence in ufshcd_add_lus() function which is invoked during
initialization only.

Link: https://lore.kernel.org/r/20210120150142.5049-3-stanley.chu@mediatek.com
Reviewed-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index d6cd30ccf90803051fcc9182a87a71aca1f5b5aa..b1b69207ca17101d1af17379a22be9c32717f0ae 100644 (file)
@@ -7768,15 +7768,14 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
                        &hba->pwr_info,
                        sizeof(struct ufs_pa_layer_attr));
                hba->clk_scaling.saved_pwr_info.is_valid = true;
-               if (!hba->devfreq) {
-                       hba->clk_scaling.is_allowed = true;
-                       ret = ufshcd_devfreq_init(hba);
-                       if (ret)
-                               goto out;
+               hba->clk_scaling.is_allowed = true;
 
-                       hba->clk_scaling.is_enabled = true;
-                       ufshcd_init_clk_scaling_sysfs(hba);
-               }
+               ret = ufshcd_devfreq_init(hba);
+               if (ret)
+                       goto out;
+
+               hba->clk_scaling.is_enabled = true;
+               ufshcd_init_clk_scaling_sysfs(hba);
        }
 
        ufs_bsg_probe(hba);