media: tda9840: cleanup a warning
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 23 Mar 2018 11:48:08 +0000 (07:48 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 23 Mar 2018 11:48:08 +0000 (07:48 -0400)
There's a false positive warning there:
drivers/media/i2c/tda9840.c:79 tda9840_status() error: uninitialized symbol 'byte'.

Change the code to match our coding style, in order to fix it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/tda9840.c

index f31e659588acb3aa8035737b795244c65b6624a7..0dd6ff3e6201a3037d128c9f1d159a278af5ea81 100644 (file)
@@ -68,11 +68,15 @@ static void tda9840_write(struct v4l2_subdev *sd, u8 reg, u8 val)
 static int tda9840_status(struct v4l2_subdev *sd)
 {
        struct i2c_client *client = v4l2_get_subdevdata(sd);
+       int rc;
        u8 byte;
 
-       if (1 != i2c_master_recv(client, &byte, 1)) {
+       rc = i2c_master_recv(client, &byte, 1);
+       if (rc != 1) {
                v4l2_dbg(1, debug, sd,
                        "i2c_master_recv() failed\n");
+               if (rc < 0)
+                       return rc;
                return -EIO;
        }