ice: Use PTP auxbus for all PHYs restart in E822
authorMichal Michalik <michal.michalik@intel.com>
Thu, 27 Jul 2023 13:50:35 +0000 (15:50 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 20 Sep 2023 15:59:26 +0000 (08:59 -0700)
The E822 (and other devices based on the same PHY) is having issue while
setting the PHC timer - the PHY timers are drifting from the PHC. After
such a set all PHYs need to be restarted and resynchronised - do it
using auxiliary bus.

Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
Signed-off-by: Michal Michalik <michal.michalik@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_ptp.c

index 9c21e81c29dbc8cb4fe9a95e446ab853f9ea73cd..503cf351f5f5996acb113058a645b544c4640584 100644 (file)
@@ -1488,6 +1488,24 @@ static void ice_ptp_reset_phy_timestamping(struct ice_pf *pf)
        ice_ptp_port_phy_restart(&pf->ptp.port);
 }
 
+/**
+ * ice_ptp_restart_all_phy - Restart all PHYs to recalibrate timestamping
+ * @pf: Board private structure
+ */
+static void ice_ptp_restart_all_phy(struct ice_pf *pf)
+{
+       struct list_head *entry;
+
+       list_for_each(entry, &pf->ptp.ports_owner.ports) {
+               struct ice_ptp_port *port = list_entry(entry,
+                                                      struct ice_ptp_port,
+                                                      list_member);
+
+               if (port->link_up)
+                       ice_ptp_port_phy_restart(port);
+       }
+}
+
 /**
  * ice_ptp_adjfine - Adjust clock increment rate
  * @info: the driver's PTP info structure
@@ -1925,9 +1943,9 @@ ice_ptp_settime64(struct ptp_clock_info *info, const struct timespec64 *ts)
        /* Reenable periodic outputs */
        ice_ptp_enable_all_clkout(pf);
 
-       /* Recalibrate and re-enable timestamp block */
-       if (pf->ptp.port.link_up)
-               ice_ptp_port_phy_restart(&pf->ptp.port);
+       /* Recalibrate and re-enable timestamp blocks for E822/E823 */
+       if (hw->phy_model == ICE_PHY_E822)
+               ice_ptp_restart_all_phy(pf);
 exit:
        if (err) {
                dev_err(ice_pf_to_dev(pf), "PTP failed to set time %d\n", err);