net: phy: mediatek-ge: do not disable EEE advertisement
authorArınç ÜNAL <arinc.unal@arinc9.com>
Sat, 13 Apr 2024 21:08:13 +0000 (00:08 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Apr 2024 09:44:20 +0000 (10:44 +0100)
The mediatek-ge PHY driver already disables EEE advertisement on the switch
PHYs but my testing [1] shows that it is somehow enabled afterwards.
Disabling EEE advertisement before the PHY driver initialises keeps it off.
Therefore, remove disabling EEE advertisement here as it's useless.

Link: https://lore.kernel.org/netdev/d286ea27-e911-4dcb-9037-b75f22b437b8@arinc9.com/
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mediatek-ge.c

index a493ae01b267a21ae778a4d72a50e6155bad1735..54ea64a37ab3a18b509e55bc6df362e8e100e8bd 100644 (file)
@@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page)
 
 static void mtk_gephy_config_init(struct phy_device *phydev)
 {
-       /* Disable EEE */
-       phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0);
-
        /* Enable HW auto downshift */
        phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4));