bpf: Disable bh in bpf_test_run for xdp and tc prog
authorMartin KaFai Lau <martin.lau@kernel.org>
Fri, 17 Feb 2023 00:41:47 +0000 (16:41 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 17 Feb 2023 15:19:23 +0000 (16:19 +0100)
Some of the bpf helpers require bh disabled. eg. The bpf_fib_lookup
helper that will be used in a latter selftest. In particular, it
calls ___neigh_lookup_noref that expects the bh disabled.

This patch disables bh before calling bpf_prog_run[_xdp], so
the testing prog can also use those helpers.

Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20230217004150.2980689-2-martin.lau@linux.dev
net/bpf/test_run.c

index 1ab396a2b87fc4715bfdbd69b0c71064fd9c6860..982e81bba6cf2eb46fa8f0502bc13d9313a14109 100644 (file)
@@ -413,10 +413,12 @@ static int bpf_test_run(struct bpf_prog *prog, void *ctx, u32 repeat,
        old_ctx = bpf_set_run_ctx(&run_ctx.run_ctx);
        do {
                run_ctx.prog_item = &item;
+               local_bh_disable();
                if (xdp)
                        *retval = bpf_prog_run_xdp(prog, ctx);
                else
                        *retval = bpf_prog_run(prog, ctx);
+               local_bh_enable();
        } while (bpf_test_timer_continue(&t, 1, repeat, &ret, time));
        bpf_reset_run_ctx(old_ctx);
        bpf_test_timer_leave(&t);