vfs: catch invalid modes in may_open()
authorMateusz Guzik <mjguzik@gmail.com>
Sun, 9 Feb 2025 18:55:21 +0000 (19:55 +0100)
committerChristian Brauner <brauner@kernel.org>
Fri, 21 Feb 2025 09:23:53 +0000 (10:23 +0100)
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20250209185523.745956-3-mjguzik@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/namei.c

index 3ab9440c5b9313bc4751ab97a1ae73194409188a..21630a0f8e30aea34294a664dc7b3a0c777cd8a4 100644 (file)
@@ -3415,6 +3415,8 @@ static int may_open(struct mnt_idmap *idmap, const struct path *path,
                if ((acc_mode & MAY_EXEC) && path_noexec(path))
                        return -EACCES;
                break;
+       default:
+               VFS_BUG_ON_INODE(1, inode);
        }
 
        error = inode_permission(idmap, inode, MAY_OPEN | acc_mode);