crypto: hmac - Make descsize an algorithm attribute
authorHerbert Xu <herbert@gondor.apana.org.au>
Sat, 12 Apr 2025 10:47:45 +0000 (18:47 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 16 Apr 2025 07:36:24 +0000 (15:36 +0800)
Rather than setting descsize in init_tfm, make it an algorithm
attribute and set it during instance construction.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/hmac.c

index 7cec25ff988915aa33497c58787f3a17130ea915..dfb153511865f96bd81e89a2cc4538dc28742b4e 100644 (file)
@@ -146,9 +146,6 @@ static int hmac_init_tfm(struct crypto_shash *parent)
        if (IS_ERR(hash))
                return PTR_ERR(hash);
 
-       parent->descsize = sizeof(struct shash_desc) +
-                          crypto_shash_descsize(hash);
-
        tctx->hash = hash;
        return 0;
 }
@@ -222,6 +219,7 @@ static int hmac_create(struct crypto_template *tmpl, struct rtattr **tb)
 
        inst->alg.digestsize = ds;
        inst->alg.statesize = ss;
+       inst->alg.descsize = sizeof(struct shash_desc) + salg->descsize;
        inst->alg.init = hmac_init;
        inst->alg.update = hmac_update;
        inst->alg.final = hmac_final;