sunrpc: xprtrdma: Use ERR_CAST() to return
authorYan Zhen <yanzhen@vivo.com>
Fri, 30 Aug 2024 01:43:56 +0000 (09:43 +0800)
committerChuck Lever <chuck.lever@oracle.com>
Fri, 20 Sep 2024 23:31:03 +0000 (19:31 -0400)
Using ERR_CAST() is more reasonable and safer, When it is necessary
to convert the type of an error pointer and return it.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/xprtrdma/svc_rdma_transport.c

index 581cc5ed7c0cb59d428b70936de708b0ea2221e1..c3fbf0779d4ab65f41a9cd0f7f5c7b8b2e4d672e 100644 (file)
@@ -369,7 +369,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
        listen_id = svc_rdma_create_listen_id(net, sa, cma_xprt);
        if (IS_ERR(listen_id)) {
                kfree(cma_xprt);
-               return (struct svc_xprt *)listen_id;
+               return ERR_CAST(listen_id);
        }
        cma_xprt->sc_cm_id = listen_id;