mm/memory-failure.c: remove obsolete comment
authorNaoya Horiguchi <naoya.horiguchi@nec.com>
Tue, 22 Mar 2022 21:44:03 +0000 (14:44 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 22 Mar 2022 22:57:06 +0000 (15:57 -0700)
With the introduction of mf_mutex, most of memory error handling process
is mutually exclusive, so the in-line comment about subtlety about
double-checking PageHWPoison is no more correct.  So remove it.

Link: https://lkml.kernel.org/r/20220125025601.3054511-1-naoya.horiguchi@linux.dev
Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/memory-failure.c

index 97a9ed8f87a96ac0a3e0ef02725b168092e7a37a..0f6413a2f30165684df323f0a82bcf9f1f6e7726 100644 (file)
@@ -2150,12 +2150,6 @@ static int __soft_offline_page(struct page *page)
                .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,
        };
 
-       /*
-        * Check PageHWPoison again inside page lock because PageHWPoison
-        * is set by memory_failure() outside page lock. Note that
-        * memory_failure() also double-checks PageHWPoison inside page lock,
-        * so there's no race between soft_offline_page() and memory_failure().
-        */
        lock_page(page);
        if (!PageHuge(page))
                wait_on_page_writeback(page);