crypto: arm/sha1-neon - Use API partial block handling
authorHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Apr 2025 02:59:25 +0000 (10:59 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 23 Apr 2025 03:33:47 +0000 (11:33 +0800)
Use the Crypto API partial block handling.

Also remove the unnecessary SIMD fallback path.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm/crypto/sha1_neon_glue.c

index 9c70b87e69f7083118a0644e65d9568d9e3d5141..d321850f22a6d0816e7d701a95de86712afc022d 100644 (file)
  *  Copyright (c) Chandramouli Narayanan <mouli@linux.intel.com>
  */
 
+#include <asm/neon.h>
 #include <crypto/internal/hash.h>
-#include <crypto/internal/simd.h>
-#include <linux/init.h>
-#include <linux/module.h>
-#include <linux/mm.h>
-#include <linux/types.h>
 #include <crypto/sha1.h>
 #include <crypto/sha1_base.h>
-#include <asm/neon.h>
-#include <asm/simd.h>
-
-#include "sha1.h"
+#include <linux/kernel.h>
+#include <linux/module.h>
 
 asmlinkage void sha1_transform_neon(struct sha1_state *state_h,
                                    const u8 *data, int rounds);
@@ -32,50 +26,37 @@ asmlinkage void sha1_transform_neon(struct sha1_state *state_h,
 static int sha1_neon_update(struct shash_desc *desc, const u8 *data,
                          unsigned int len)
 {
-       struct sha1_state *sctx = shash_desc_ctx(desc);
-
-       if (!crypto_simd_usable() ||
-           (sctx->count % SHA1_BLOCK_SIZE) + len < SHA1_BLOCK_SIZE)
-               return sha1_update_arm(desc, data, len);
+       int remain;
 
        kernel_neon_begin();
-       sha1_base_do_update(desc, data, len, sha1_transform_neon);
+       remain = sha1_base_do_update_blocks(desc, data, len,
+                                           sha1_transform_neon);
        kernel_neon_end();
 
-       return 0;
+       return remain;
 }
 
 static int sha1_neon_finup(struct shash_desc *desc, const u8 *data,
                           unsigned int len, u8 *out)
 {
-       if (!crypto_simd_usable())
-               return sha1_finup_arm(desc, data, len, out);
-
        kernel_neon_begin();
-       if (len)
-               sha1_base_do_update(desc, data, len, sha1_transform_neon);
-       sha1_base_do_finalize(desc, sha1_transform_neon);
+       sha1_base_do_finup(desc, data, len, sha1_transform_neon);
        kernel_neon_end();
 
        return sha1_base_finish(desc, out);
 }
 
-static int sha1_neon_final(struct shash_desc *desc, u8 *out)
-{
-       return sha1_neon_finup(desc, NULL, 0, out);
-}
-
 static struct shash_alg alg = {
        .digestsize     =       SHA1_DIGEST_SIZE,
        .init           =       sha1_base_init,
        .update         =       sha1_neon_update,
-       .final          =       sha1_neon_final,
        .finup          =       sha1_neon_finup,
-       .descsize       =       sizeof(struct sha1_state),
+       .descsize               = SHA1_STATE_SIZE,
        .base           =       {
                .cra_name               = "sha1",
                .cra_driver_name        = "sha1-neon",
                .cra_priority           = 250,
+               .cra_flags              = CRYPTO_AHASH_ALG_BLOCK_ONLY,
                .cra_blocksize          = SHA1_BLOCK_SIZE,
                .cra_module             = THIS_MODULE,
        }