regulator: core: resolve supply voltage deferral silently
authorBrian Norris <briannorris@chromium.org>
Thu, 26 Aug 2021 19:40:17 +0000 (12:40 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 13 Sep 2021 00:59:25 +0000 (01:59 +0100)
Voltage-controlled regulators depend on their supply regulator for
retrieving their voltage, and so they might return -EPROBE_DEFER at this
stage. Our caller already attempts to resolve supplies and retry, so we
shouldn't be printing this error to logs.

Quiets log messages like this, on Rockchip RK3399 Gru/Kevin boards:

[    1.033057] ppvar_bigcpu: failed to get the current voltage: -EPROBE_DEFER
...
[    1.036735] ppvar_litcpu: failed to get the current voltage: -EPROBE_DEFER
...
[    1.040366] ppvar_gpu: failed to get the current voltage: -EPROBE_DEFER
...
[    1.044086] ppvar_centerlogic: failed to get the current voltage: -EPROBE_DEFER

Cc: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20210826124015.1.Iab79c6dd374ec48beac44be2fcddd165dd26476b@changeid
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c

index ca6caba8a191afff2e20d02100f87b219e319ec0..85783fb3aadfbdd3869fc33cce3101b538b30d9d 100644 (file)
@@ -1151,9 +1151,10 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
                }
 
                if (current_uV < 0) {
-                       rdev_err(rdev,
-                                "failed to get the current voltage: %pe\n",
-                                ERR_PTR(current_uV));
+                       if (current_uV != -EPROBE_DEFER)
+                               rdev_err(rdev,
+                                        "failed to get the current voltage: %pe\n",
+                                        ERR_PTR(current_uV));
                        return current_uV;
                }