ovpn: drop useless reg_state check in keepalive worker

The keepalive worker is cancelled before calling
unregister_netdevice_queue(), therefore it will never
hit a situation where the reg_state can be different
than NETDEV_REGISTERED.

For this reason, checking reg_state is useless and the
condition can be removed.

Signed-off-by: Antonio Quartulli <antonio@openvpn.net>

diff --git a/drivers/net/ovpn/peer.c b/drivers/net/ovpn/peer.c
index a37f89fffb02efbb6468d54c93247b170b5d11f6..24eb9d81429ee652d7106db9e0ea7fa60430cce5 100644 (file)
--- a/drivers/net/ovpn/peer.c
+++ b/drivers/net/ovpn/peer.c
@@ -1353,8 +1353,7 @@ void ovpn_peer_keepalive_work(struct work_struct *work)
        }
 
        /* prevent rearming if the interface is being destroyed */
-       if (next_run > 0 &&
-           READ_ONCE(ovpn->dev->reg_state) == NETREG_REGISTERED) {
+       if (next_run > 0) {
                netdev_dbg(ovpn->dev,
                           "scheduling keepalive work: now=%llu next_run=%llu delta=%llu\n",
                           next_run, now, next_run - now);